fix issue 145. raise Exception when concatenate method != chain or c… #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remind me what problem this solves ? Edit: I mean the function-name-grabbing thing. |
|
@Zulko. The method argument of concatenate (and concatenate_videoclips) should only be set to chain or compose. It was requested that if method was set to something else, an error should be raised. |
|
Ok, but the name detection is unnecessary in my opinion, a simple message would do. |
|
Thanks, @Zulko , I've make those changes. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #145 give a clear error message when we pass an incorrect value to concatenate_videoclip, method argument.